Hi Manny,

If you hardcode the variable into GRRLIB_Init(), you should better name those variables GRRLIB_SCR_WIDTH and GRRLIB_SCR_HEIGHT.

And looking at GRRLIB_Line() code you will see that it calls GRRLIB_NGone(), so probably you will not gain much performance.

Before of writting any more: I am not trying to say that anybody has done something wrong in grrLib. The quality of your demos and the number of projects in wiibrew using grrLib does matter much more than my opinion.

What a said is that manny2008 won't probably gain performance by using GRRLIB_NGone instead od GRRLIB_Line. The reason is clear... everyone is using GRRLIB_NGone today due to it implementation.


Also, I have not decompiled a grrlib program, but I have done before with gcc code (which is the compiler used in devkitppc). My impression is that gcc does a good work in inlinning code, but sometimes you can do even better by hand...


Now I will try to analyze the 4.1 grrlib trunk code

1. void  GRRLIB_Line const f32 x1, const f32 y1, const f32 x2, const f32 y2, const u32 color)
1.1 guVector v[] = {{x1,y1,0.0f}, {x2,y2,0.0f}};
1.2 u32 ncolor[] = {color,color};
1.3 GRRLIB_NGone(v, ncolor, 2);

2. GRRLIB_NGone (const guVector v[], const u32 color[], const long n)
2.1    GRRLIB_GXEngine(v, color, n, GX_LINESTRIP);

3. void  GRRLIB_GXEngine (const guVector v[], const u32 color[], const long n, const u8 fmt)
3.1  int i;
3.2    GX_Begin(fmt, GX_VTXFMT0, n);
3.3    for (i = 0; i < n; i++) {
3.4        GX_Position3f32(v[i].x, v[i].y,  v[i].z);
3.5        GX_Color1u32(color[i]);
3.6    GX_End();

The overhead will come from the deep recursion (which will not be much due to inlinning) and also from the construction
of data structures as (1.1 and 1.2) that later must be deconstructed. This will be a SMALL overhead, as you stated, but if
you call GRRLIB_Line() inside a loop you will get a sum of small overheads and also an use of registers that may be not optimus.

So, as yourself  have decoded your code in this post. Why not use?

void  GRRLIB_Line const f32 x1, const f32 y1, const f32 x2, const f32 y2, const u32 color)
{
    GX_Begin(GX_LINES, GX_VTXFMT0, 2);
        GX_Position3f32(x1, y1,  0);
        GX_Color1u32(color);
        GX_Position3f32(x2, y2, 0);
        GX_Color1u32(color);
    GX_End();
}

Edit: This code is tested and working !!!

And I am not sure if you can do even better

void  GRRLIB_Line const f32 x1, const f32 y1, const f32 x2, const f32 y2, const u32 color)
{
    GX_Begin(GX_LINES, GX_VTXFMT0, 2);
EDIT:  OOOOPS. THIS CODE DOES NOT WORK!
        GX_Color1u32(color);
        GX_Position3f32(x1, y1,  0);
        GX_Position3f32(x2, y2, 0);
    GX_End();
}

Edit: This code is tested and crashed my wii


Same applies to GRRLIB_Plot(), but it is possible to do even better using the framebuffer (but you need to do that strange color conversion from RGBA to YUYUV)

Last edited by jespa (2009-08-19 17:51:51)

Hey JESPA,

First, I'd like to take a brief moment to address your opening comment:

Before of writting any more: I am not trying to say that anybody has done something wrong in grrLib. The quality of your demos and the number of projects in wiibrew using grrLib does matter much more than my opinion.

As the newest member of the GRRLIB Team, I feel I am best placed to say that everyone here is friendly, open minded, and without false ego.  We enjoy the chance to see old things in new ways - your opinion does matter

Secondly.  Your code breakdown...
There seems to be only one way to answer:
Yes.  You're right.  Thank You.  Your changes are now in SVN with your name in the credits & doxygen headers.

BC

jespa : another soon new GRRLIB team member ??

What about a little intro or demo in cooperation with motivated ppl ?

In fact, while was writing the page on wiibrew to prepare the release I found that somebody had modified my page just 3 minutes after my last change... and had deleted my download section!

When I looked for the Bad Mother Fucker that deleted it... I saw that he is our B.M.F. on here. And my download section is not missed, it was just moved to a cool box on the right of the page. Thanks for your help Crayon

Of course, the source code is going to be released. I am just studying the best option. Project on code.google? A firewii.src.rar file at wiibrew? Not sure yet, but I wanted to publish the code in this forum before, just to have the ability to receive comments and suggestions about it.

I suppose that if GRRLIB accept it as a demo, the best publication method is just a link to GRRLIB subversion.

And please, move to this post to further talking about firewii. This is the manny2008 post, not mine.